Return-path: Received: from mail.atheros.com ([12.36.123.2]:62815 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862Ab0FDVVr (ORCPT ); Fri, 4 Jun 2010 17:21:47 -0400 Received: from mail.atheros.com ([10.10.20.105]) by sidewinder.atheros.com for ; Fri, 04 Jun 2010 14:21:47 -0700 Date: Fri, 4 Jun 2010 14:21:45 -0700 From: "Luis R. Rodriguez" To: "John W. Linville" CC: Bruno Randolf , "ath5k-devel@lists.ath5k.org" , "linux-wireless@vger.kernel.org" , David Quan , Aeolus Yang , Johannes Berg Subject: Re: [ath5k-devel] [PATCH v2 13/20] cfg80211: Add nl80211 antenna configuration Message-ID: <20100604212145.GB4069@tux> References: <20100519012528.22206.77550.stgit@tt-desk> <20100519013147.22206.71360.stgit@tt-desk> <20100604193009.GD2492@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20100604193009.GD2492@tuxdriver.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Jun 04, 2010 at 12:30:09PM -0700, John W. Linville wrote: > On Wed, May 19, 2010 at 10:31:48AM +0900, Bruno Randolf wrote: > > Allow setting TX and RX antenna configuration via nl80211/cfg80211. > > > > The antenna configuration is defined as a bitmap of allowed antennas. This > > bitmap is 8 bit at the moment, each bit representing one antenna. If multiple > > antennas are selected, the driver may use diversity for receive and transmit. > > This allows for a simple, yet flexible configuration interface for antennas, > > while drivers may reject configurations they cannot support. > > > > Signed-off-by: Bruno Randolf > > This spawned a long thread, that isn't clearly resolved IMHO. So, I > haven't merged it, or the other patches that follow it in this series. > > Am I mistaken? Did this get resolved? If not, are some of the later > patches still interesting? > > Unless I hear otherwise, I'll be dropping the rest of this series... I don't think the API is defined clean enough yet and can yield inconsistant interpretations. I'd like to see this clarified on the documentation for both legacy and 802.11n. If the plan is to support only legacy right now then I think the API can be simpler and clearer with only three options passed, Fixed_A Fixed_B and diversity. Luis