Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:57946 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752296Ab0FIN6k (ORCPT ); Wed, 9 Jun 2010 09:58:40 -0400 MIME-Version: 1.0 In-Reply-To: <4c0f4326.0a41df0a.7bde.ffffeef2@mx.google.com> References: <4c0f4326.0a41df0a.7bde.ffffeef2@mx.google.com> Date: Wed, 9 Jun 2010 09:58:37 -0400 Message-ID: Subject: Re: [ath5k-devel] [PATCH] [ath5k][leds] Ability to disable leds support. If leds support enabled do not force mac802.11 leds layer selection. From: Bob Copeland To: Dmytro Milinevskyy Cc: ath5k-devel@lists.ath5k.org, Kalle Valo , linux-wireless@vger.kernel.org, GeunSik Lim , Jiri Slaby , Greg Kroah-Hartman , "John W. Linville" , Keng-Yu Lin , netdev@vger.kernel.org, Jiri Kosina , Shahar Or , linux-kernel@vger.kernel.org, Luca Verdesca Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jun 9, 2010 at 3:31 AM, Dmytro Milinevskyy wrote: > However if the leds support was enabled do not force selection of 802.11 leds layer. I don't understand this part. What's the point of enabling software LEDs if nothing triggers them? Also, we can probably build hardware LEDs (hw_set_ledstate) in regardless. It's a pure register write and doesn't require the rest of the LED machinery. I assume you are doing this to reduce the size of the module. If so, can you include size(1) output in the commit message? -- Bob Copeland %% www.bobcopeland.com