Return-path: Received: from mail-pv0-f174.google.com ([74.125.83.174]:56294 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758910Ab0FPPtz (ORCPT ); Wed, 16 Jun 2010 11:49:55 -0400 Received: by pva4 with SMTP id 4so717620pva.19 for ; Wed, 16 Jun 2010 08:49:47 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4C18D2A5.5080702@gmail.com> References: <1276640359-25360-1-git-send-email-lrodriguez@atheros.com> <20100616081227.GA1118@boggieman> <4C18D2A5.5080702@gmail.com> From: "Luis R. Rodriguez" Date: Wed, 16 Jun 2010 08:49:24 -0700 Message-ID: Subject: Re: [PATCH 2.6.32.y] ath9k: re-enable ps by default for new single chip families To: "Justin P. Mattock" Cc: Kristoffer Ericson , stable@kernel.org, greg@kroah.com, linux-wireless@vger.kernel.org, Peter Stuge , "John W. Linville" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jun 16, 2010 at 6:33 AM, Justin P. Mattock wrote: > On 06/16/2010 01:12 AM, Kristoffer Ericson wrote: >> >> On Tue, Jun 15, 2010 at 06:19:19PM -0400, Luis R. Rodriguez wrote: >>> >>> commit 14acdde6e527950f66c084dbf19bad6fbfcaeedc upstream. >>> >>> The newer single chip hardware family of chipsets have not been >>> experiencing issues with power saving set by default with recent >>> fixes merged (even into stable). The remaining issues are only >>> reported with AR5416 and since enabling PS by default can increase >>> power savings considerably best to take advantage of that feature >>> as this has been tested properly. >> >> I havent had any issues lately. But that said Ive moved on to >> 2.6.33, 2.6.34 which seems to work fine. Believe you set >> to disabled by default on those? >> >> /Kristoffer >> > > just tried to add this patch to the latest HEAD, but realized > ath_set_hw_capab is missing(or I cant seem to grep it) > if you have a patch for the latest tree let me know I can see if I'm hitting > anything like before. The patch would already be merged since 2.6.33.y, this patch is a backport for 2.6.32.y. I just hadn't had time to backport it yet, until today. Luis