Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:58403 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756579Ab0FYRne convert rfc822-to-8bit (ORCPT ); Fri, 25 Jun 2010 13:43:34 -0400 Received: by iwn41 with SMTP id 41so2219693iwn.19 for ; Fri, 25 Jun 2010 10:43:32 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Fri, 25 Jun 2010 14:43:31 -0300 Message-ID: Subject: Fwd: mesh configuration information element is wrong? From: Iuri Diniz To: linux-wireless@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hello folks, I'm analyzing the 802.11s code and I think I've found that mesh configuration information element has wrongs sizes. It is not according to my copy of 802.11s draft 3. on linux-wireless-testing/linux/include/ieee80211.h we have: -------- /** ?* struct ieee80211_meshconf_ie ?* ?* This structure refers to "Mesh Configuration information element" ?*/ struct ieee80211_meshconf_ie { ??? u8 meshconf_psel; ??? u8 meshconf_pmetric; ??? u8 meshconf_congest; ??? u8 meshconf_synch; ??? u8 meshconf_auth; ??? u8 meshconf_form; ??? u8 meshconf_cap; } __attribute__ ((packed)); ---------- All fields have 1 byte, but according to http://i45.tinypic.com/4ghhd1.jpg some of they must have 4 or 2 bytes the function mesh.c:mesh_mgmt_ies_add uses those wrong sizes to prepare the management frame. Is there a new draft? or is there any reason to use those sizes? (March 2009) Draft 3 802.11s MESH CONFIGURATION ELEMENT: http://i45.tinypic.com/4ghhd1.jpg -- Iuri Diniz http://iuridiniz.com [Sou um agitador, n?o um advogado] http://blog.igdium.com [Linux on Limbo]