Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:34270 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775Ab0GURPR (ORCPT ); Wed, 21 Jul 2010 13:15:17 -0400 Date: Wed, 21 Jul 2010 13:11:53 -0400 From: "John W. Linville" To: Larry Finger Cc: Michael =?iso-8859-1?Q?B=FCsch?= , linux-wireless@vger.kernel.org, Larry Finger , =?iso-8859-1?Q?G=E1bor?= Stefanik , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH] b43: silense most sparse warnings Message-ID: <20100721171153.GD2355@tuxdriver.com> References: <1279727142-25234-1-git-send-email-linville@tuxdriver.com> <4C471AC2.5040003@bu3sch.de> <4C4724C5.4080400@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <4C4724C5.4080400@lwfinger.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jul 21, 2010 at 11:48:05AM -0500, Larry Finger wrote: > On 07/21/2010 11:05 AM, Michael B?sch wrote: > >On 07/21/2010 05:45 PM, John W. Linville wrote: > >>diff --git a/drivers/net/wireless/b43/phy_g.c b/drivers/net/wireless/b43/phy_g.c > >>index 29bf34c..0dc33b6 100644 > >>--- a/drivers/net/wireless/b43/phy_g.c > >>+++ b/drivers/net/wireless/b43/phy_g.c > >>@@ -972,7 +972,7 @@ b43_radio_interference_mitigation_enable(struct b43_wldev > >>*dev, int mode) > >>b43_phy_maskset(dev, 0x04A2, 0xFFF0, 0x000B); > >> > >>if (phy->rev>= 3) { > >>- b43_phy_mask(dev, 0x048A, (u16)~0x8000); > >>+ b43_phy_mask(dev, 0x048A, 0x7FFF); > > > >This cast was introduced to silense a GCC warning. Do we end up in an > >infinite loop now? ;) > > I get no GCC warnings here with the change. I think it is OK. > > Is silense a valid British spelling? I prefer silence. Just a typo. :-) > Do you wish to clean up the warnings from the N-PHY code as well? > Ignoring the "should it be static?" parts, I get the following > sparse warnings: > > drivers/net/wireless/b43/phy_n.c:512:53: warning: cast truncates > bits from constant value (ffff0fff becomes fff) > drivers/net/wireless/b43/phy_n.c:765:66: warning: cast truncates > bits from constant value (ffff7fff becomes 7fff) > drivers/net/wireless/b43/phy_n.c:1012:38: warning: cast truncates > bits from constant value (ffff00ff becomes ff) > drivers/net/wireless/b43/phy_n.c:1119:38: warning: cast truncates > bits from constant value (ffff0fff becomes fff) > drivers/net/wireless/b43/phy_n.c:2458:56: warning: cast truncates > bits from constant value (ffff7fff becomes 7fff) > drivers/net/wireless/b43/phy_n.c:2933:38: warning: cast truncates > bits from constant value (ffff0fff becomes fff) > drivers/net/wireless/b43/phy_n.c:3294:57: warning: cast truncates > bits from constant value (ffff3fff becomes 3fff) > > The patch for them is below. Seems fine -- shall I add your Signed-off-by? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.