Return-path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:36808 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752748Ab0GWJPH (ORCPT ); Fri, 23 Jul 2010 05:15:07 -0400 Date: Fri, 23 Jul 2010 10:15:04 +0100 From: Mark Brown To: Ohad Ben-Cohen Cc: Roger Quadros , "linux-wireless@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-omap@vger.kernel.org" , Kalle Valo , Pandita Vikram , "linux@arm.linux.org.uk" , Nicolas Pitre , Tony Lindgren , San Mehat , Chikkature Rajashekar Madhusudhan , "Coelho Luciano (Nokia-MS/Helsinki)" , "akpm@linux-foundation.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 10/20] omap: zoom: add fixed regulator device for wlan Message-ID: <20100723091503.GA12300@rakim.wolfsonmicro.main> References: <1279733634-21974-1-git-send-email-ohad@wizery.com> <1279733634-21974-11-git-send-email-ohad@wizery.com> <20100721175930.GD10930@sirena.org.uk> <4C48287D.1000603@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Jul 23, 2010 at 02:13:38AM +0300, Ohad Ben-Cohen wrote: > On Thu, Jul 22, 2010 at 2:16 PM, Roger Quadros wrote: > > .dev_name ? ? ? = "mmci-omap-hs.2" > I already set the .dev member of the consumer in a similar manner to > how all other regulators are configured in this board - please check > out patch 13: > https://patchwork.kernel.org/patch/113418/ > Does this look reasonable to you ? You should really be using dev_name in preference to dev these days unless there's a *very* good reason.