Return-path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:56707 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716Ab0G0P6N (ORCPT ); Tue, 27 Jul 2010 11:58:13 -0400 MIME-Version: 1.0 In-Reply-To: <1280223313.3721.83.camel@maxim-laptop> References: <20100726210651.GJ14855@tux> <1280179033.3721.15.camel@maxim-laptop> <20100726212543.GA5424@srcf.ucam.org> <20100726222113.GA6487@srcf.ucam.org> <20100726222909.GA6773@srcf.ucam.org> <20100726223326.GA6904@srcf.ucam.org> <20100726225057.GA7268@srcf.ucam.org> <1280223313.3721.83.camel@maxim-laptop> From: "Luis R. Rodriguez" Date: Tue, 27 Jul 2010 08:57:51 -0700 Message-ID: Subject: Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM To: Maxim Levitsky Cc: Matthew Garrett , "ath5k-devel@lists.ath5k.org" , "linux-wireless@vger.kernel.org" , David Quan , "Luis R. Rodriguez" , linux-kernel , "kernel-team@lists.ubuntu.com" , Luis Rodriguez , Jussi Kivilinna , "tim.gardner@canonical.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Jul 27, 2010 at 2:35 AM, Maxim Levitsky wrote: > On Mon, 2010-07-26 at 23:50 +0100, Matthew Garrett wrote: >> On Mon, Jul 26, 2010 at 03:43:04PM -0700, Luis R. Rodriguez wrote: >> >> > I see.. thanks Mathew... in that case since L1 works on all devices we >> > could just force enable L1 for all PCIE devices. What do you think? >> >> Works for me. >> > > On the second thought, there is no 'pci_enable_link_state' :-) > I afraid that if I add it, I might not do that right for all cases, thus > do more harm that good... I'm sorry, can you elaborate? Luis