Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:54986 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752922Ab0GZV0I (ORCPT ); Mon, 26 Jul 2010 17:26:08 -0400 Date: Mon, 26 Jul 2010 22:25:43 +0100 From: Matthew Garrett To: Maxim Levitsky Cc: "Luis R. Rodriguez" , Luis Rodriguez , Bob Copeland , "Luis R. Rodriguez" , Jussi Kivilinna , "ath5k-devel@lists.ath5k.org" , "linux-wireless@vger.kernel.org" , linux-kernel , "kernel-team@lists.ubuntu.com" , "tim.gardner@canonical.com" , David Quan Subject: Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM Message-ID: <20100726212543.GA5424@srcf.ucam.org> References: <1276870309.23783.3.camel@maxim-laptop> <1276933774.16697.11.camel@maxim-laptop> <20100619123841.GA31838@hash.localnet> <1276952554.3332.3.camel@maxim-laptop> <1276961564.5173.12.camel@maxim-laptop> <20100726201322.GI14855@tux> <1280177362.3721.7.camel@maxim-laptop> <20100726210651.GJ14855@tux> <1280179033.3721.15.camel@maxim-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1280179033.3721.15.camel@maxim-laptop> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Jul 27, 2010 at 12:17:13AM +0300, Maxim Levitsky wrote: > However, it is possible, (and that what I asked you) that some ath5k > devices aren't 'pre 1.1 pcie devices' so linux won't disable ASPM L0s > for them. > So indeed for 'good feeling' it is ok to disable L0s from ath5k > explicitly, but most of the time (or always) it will be no-op. > > In *addition* to that, since you said that ASPM L1 *does* work, and is > enabled by BIOS, but linux disables it, that it might be worthy to > enable it again from ath5k driver explicitly. > As long as wireless works I don't really care if this done or not. This may need to be done on a chip by chip basis. Take a look at http://www.atheros.cz/inffile.php?inf=68&bit=32&atheros=AR5002G&system=4 and some of the other inf files on that site to see which devices provide the PciASPMOptIn flag - those should support ASPM states even if they're pre-1.1 devices. -- Matthew Garrett | mjg59@srcf.ucam.org