Return-path: Received: from mail.redfish-solutions.com ([66.232.79.143]:34545 "EHLO mail.redfish-solutions.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752526Ab0GNTmV (ORCPT ); Wed, 14 Jul 2010 15:42:21 -0400 Message-ID: <4C3E1315.5050607@redfish-solutions.com> Date: Wed, 14 Jul 2010 13:42:13 -0600 From: "Philip A. Prindeville" MIME-Version: 1.0 To: "Luis R. Rodriguez" CC: Hauke Mehrtens , linux-wireless@vger.kernel.org, mcgrof@infradead.org Subject: Re: [PATCH] compat-wireless: fix build of ath5k for CONFIG_PM_SLEEP=n References: <1278879791-12646-1-git-send-email-hauke@hauke-m.de> <4C3B6AAE.4070204@redfish-solutions.com> <4C3DFDB5.10904@redfish-solutions.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 07/14/2010 12:33 PM, Luis R. Rodriguez wrote: > On Wed, Jul 14, 2010 at 11:11 AM, Philip A. Prindeville > wrote: >> On 07/13/2010 04:44 PM, Luis R. Rodriguez wrote: >>> On Tue, Jul 13, 2010 at 2:54 PM, Luis R. Rodriguez >>> wrote: >>>> On Mon, Jul 12, 2010 at 12:19 PM, Philip A. Prindeville >>>> wrote: >>>>> On 07/12/2010 09:30 AM, Luis R. Rodriguez wrote: >>>>>> On Sun, Jul 11, 2010 at 1:23 PM, Hauke Mehrtens wrote: >>>>>>> suspend and resume are activated in ath5k if CONFIG_PM_SLEEP is set and >>>>>>> not if just CONFIG_PM is set. >>>>>>> >>>>>>> This should fix the problems reported by Philip Prindeville. >>>>>>> >>>>>>> Signed-off-by: Hauke Mehrtens >>>>>> >>>>>> Thanks! Applied and pushed out, at noon we'll have a new tarball with this. >>>>>> >>>>>> Luis >>>>> >>>>> And... >>>>> >>>>> >>>>> CC [M] /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.o >>>>> /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.c: In function 'l2cap_data_channel': >>>>> /home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.c:4352: error: void value not ignored as it ought to be >>>>> make[4]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth/l2cap.o] Error 1 >>>>> make[3]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/bluetooth] Error 2 >>>>> make[2]: *** [_module_/home/philipp/kernel/build_i586/compat-wireless-2010-07-12] Error 2 >>>>> make[2]: Leaving directory `/home/philipp/kernel/build_i586/linux-2.6.27.48-astlinux' >>>>> make[1]: *** [modules] Error 2 >>>>> make[1]: Leaving directory `/home/philipp/kernel/build_i586/compat-wireless-2010-07-12' >>>>> make: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-12/net/wireless/lib80211.ko] Error 2 >>>> >>>> Thanks for reporting this, I am working on it now. >>> >>> This is now fixed, I'll push out a new tarball shortly. >>> >>> Luis >> >> That tarball never made it out... can you please retry? > > The cronjob kicks off at noon PST time. > > Luis Just picked up the tarball: /home/philipp/kernel/build_i586/compat-wireless-2010-07-14/drivers/net/wireless/rt2x00/rt2x00pci.c: In function 'rt2x00pci_initialize': /home/philipp/kernel/build_i586/compat-wireless-2010-07-14/drivers/net/wireless/rt2x00/rt2x00pci.c:156: error: implicit declaration of function 'request_threaded_irq' make[5]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-14/drivers/net/wireless/rt2x00/rt2x00pci.o] Error 1 make[4]: *** [/home/philipp/kernel/build_i586/compat-wireless-2010-07-14/drivers/net/wireless/rt2x00] Error 2 make[4]: *** Waiting for unfinished jobs.... I'm thinking that it might be good to have a variety of nightly builds to detect damage. Do you all have infrastructure for that? This is building against 2.6.27.48