Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:41886 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797Ab0GYKkf convert rfc822-to-8bit (ORCPT ); Sun, 25 Jul 2010 06:40:35 -0400 MIME-Version: 1.0 In-Reply-To: <20100723091503.GA12300@rakim.wolfsonmicro.main> References: <1279733634-21974-1-git-send-email-ohad@wizery.com> <1279733634-21974-11-git-send-email-ohad@wizery.com> <20100721175930.GD10930@sirena.org.uk> <4C48287D.1000603@nokia.com> <20100723091503.GA12300@rakim.wolfsonmicro.main> From: Ohad Ben-Cohen Date: Sun, 25 Jul 2010 13:40:13 +0300 Message-ID: Subject: Re: [PATCH v2 10/20] omap: zoom: add fixed regulator device for wlan To: Mark Brown Cc: Roger Quadros , "linux-wireless@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-omap@vger.kernel.org" , Kalle Valo , Pandita Vikram , "linux@arm.linux.org.uk" , Nicolas Pitre , Tony Lindgren , San Mehat , Chikkature Rajashekar Madhusudhan , "Coelho Luciano (Nokia-MS/Helsinki)" , "akpm@linux-foundation.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Jul 23, 2010 at 12:15 PM, Mark Brown wrote: > On Fri, Jul 23, 2010 at 02:13:38AM +0300, Ohad Ben-Cohen wrote: >> On Thu, Jul 22, 2010 at 2:16 PM, Roger Quadros wrote: >> > .dev_name ? ? ? = "mmci-omap-hs.2" > >> I already set the .dev member of the consumer in a similar manner to >> how all other regulators are configured in this board - please check >> out patch 13: > >> https://patchwork.kernel.org/patch/113418/ > >> Does this look reasonable to you ? > > You should really be using dev_name in preference to dev these days > unless there's a *very* good reason. Changed, thank you. I'll submit the updated patch now as a standalone patch as it has no dependencies on the whole series, and it could only help to start trimming that series down. >