Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:59032 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759338Ab0GBRVQ (ORCPT ); Fri, 2 Jul 2010 13:21:16 -0400 Subject: Re: [PATCH 2.6.34] mac80211: Fix auth retries if AP sends temporary deauth From: Johannes Berg To: Paul Stewart Cc: linux-wireless@vger.kernel.org, Michael Wu , Jiri Benc , "John W. Linville" In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Fri, 02 Jul 2010 19:21:12 +0200 Message-ID: <1278091272.15412.12.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2010-07-01 at 10:21 -0700, Paul Stewart wrote: > This bypasses destruction of BSS state if a temporary DEAUTH packet is > received while performing an AUTH. This will allow the retry mechanism > (which runs regardless of this patch) to succeed, since we do not remove > the BSS state which is required to complete authentication on the client > side in cfg80211_send_rx_auth(). > > The specific case handled here is "Previous authentication no longer > valid", which is usually generated by an AP if the AP still has saved > state of the STA being authenticated. Usually a retry will be successful. You don't usually send patches to stable, you send them to the current tree with a cc stable tag, and then they get picked up. I'm going to look at the problem now, I'm still not really convinced by this. johannes