Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:54749 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752801Ab0H3OOx (ORCPT ); Mon, 30 Aug 2010 10:14:53 -0400 Date: Mon, 30 Aug 2010 10:12:19 -0400 From: "John W. Linville" To: Larry Finger Cc: Thadeu Lima de Souza Cascardo , linux-wireless@vger.kernel.org, Rogerio Luz Coelho , Herton Ronaldo Krzesinski , Hin-Tak Leung Subject: Re: [PATCH] rtl8187b: do not do per packet TX AGC Message-ID: <20100830141218.GB30864@tuxdriver.com> References: <1282974868-22237-1-git-send-email-cascardo@holoscopio.com> <4C798080.8010002@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4C798080.8010002@lwfinger.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, Aug 28, 2010 at 04:32:48PM -0500, Larry Finger wrote: > On 08/28/2010 12:54 AM, Thadeu Lima de Souza Cascardo wrote: > > The code for rtl8187 does not do per packet TX AGC. Resetting the per > > packet TX AGC for rtl8187b appears to increase its overall TX power. > > This allows the device to associate and a connection be established > > using APs a little further away. > > > > Tested-by: Thadeu Lima de Souza Cascardo > > Signed-off-by: Thadeu Lima de Souza Cascardo > > Cc: linux-wireless@vger.kernel.org > > Cc: Larry Finger > > Cc: Rogerio Luz Coelho > > Cc: Herton Ronaldo Krzesinski > > Cc: Hin-Tak Leung > > --- > > I'm a little confused here. The subject says not to set the per packet TX AGC, > while the submission text says that setting it helps. I don't have access to any > documents that describe this register, but I expect that clearing > RTL818X_TX_AGC_CTL_PERPACKET_GAIN_SHIFT would disable that feature. As a result > the code change seems to match the subject. > > I have not yet tested this code, but I do note that all the Realtek drivers for > the RTL8187B set this bit. > > Until testing, I withhold judgment on the actual code change, but NACK for the > inconsistency. Perhaps the word "clearing" rather than "resetting" would be less confusing? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.