Return-path: Received: from smtp.nokia.com ([192.100.122.233]:33854 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734Ab0HKK3c (ORCPT ); Wed, 11 Aug 2010 06:29:32 -0400 Message-ID: <4C627B5C.6070803@nokia.com> Date: Wed, 11 Aug 2010 13:28:44 +0300 From: Adrian Hunter MIME-Version: 1.0 To: Ohad Ben-Cohen CC: "linux-wireless@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-omap@vger.kernel.org" , Mark Brown , "linux-arm-kernel@lists.infradead.org" , Chikkature Rajashekar Madhusudhan , "Coelho Luciano (Nokia-MS/Helsinki)" , "akpm@linux-foundation.org" , San Mehat , "Quadros Roger (Nokia-MS/Helsinki)" , Tony Lindgren , Nicolas Pitre , Pandita Vikram , Kalle Valo Subject: Re: [PATCH v3 6/9] omap: hsmmc: remove unused variable References: <1281478348-24833-1-git-send-email-ohad@wizery.com> <1281478348-24833-7-git-send-email-ohad@wizery.com> <4C627378.2090304@nokia.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Ohad Ben-Cohen wrote: > On Wed, Aug 11, 2010 at 12:55 PM, Adrian Hunter wrote: >> Ohad Ben-Cohen wrote: >>> Make this go away: >>> >>> drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend': >>> drivers/mmc/host/omap_hsmmc.c:2328: warning: unused variable 'state' >> Was done a while ago. > > Are you sure ? Oops sorry =0_o= It is still there. > > I can still see the unused state variable in Linus' tree: > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/mmc/host/omap_hsmmc.c;h=b032828c61263028963bd412a7455546d5e86ce7;hb=HEAD#l2275 > > >> See 1a13f8fa76c880be41d6b1e6a2b44404bcbfdf9e in linus' tree. > > This commit only seem to adapt to the API change (the state variable > is not removed): > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index d25b19b..b032828 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -2292,7 +2292,7 @@ static int omap_hsmmc_suspend(struct device *dev) > } > cancel_work_sync(&host->mmc_carddetect_work); > mmc_host_enable(host->mmc); > - ret = mmc_suspend_host(host->mmc, state); > + ret = mmc_suspend_host(host->mmc); > if (ret == 0) { > omap_hsmmc_disable_irq(host); > OMAP_HSMMC_WRITE(host->base, HCTL, > >>> Signed-off-by: Ohad Ben-Cohen >>> --- >>> drivers/mmc/host/omap_hsmmc.c | 1 - >>> 1 files changed, 0 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c >>> index b032828..d50e917 100644 >>> --- a/drivers/mmc/host/omap_hsmmc.c >>> +++ b/drivers/mmc/host/omap_hsmmc.c >>> @@ -2272,7 +2272,6 @@ static int omap_hsmmc_suspend(struct device *dev) >>> int ret = 0; >>> struct platform_device *pdev = to_platform_device(dev); >>> struct omap_hsmmc_host *host = platform_get_drvdata(pdev); >>> - pm_message_t state = PMSG_SUSPEND; /* unused by MMC core */ >>> if (host && host->suspended) >>> return 0; >> >