Return-path: Received: from mail-qy0-f174.google.com ([209.85.216.174]:45681 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755970Ab0HQGi0 convert rfc822-to-8bit (ORCPT ); Tue, 17 Aug 2010 02:38:26 -0400 Received: by qyk10 with SMTP id 10so321368qyk.19 for ; Mon, 16 Aug 2010 23:38:11 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4C69A3E4.1080807@bu3sch.de> References: <1281991157-1557-1-git-send-email-netrolller.3d@gmail.com> <1281991157-1557-2-git-send-email-netrolller.3d@gmail.com> <1281991157-1557-3-git-send-email-netrolller.3d@gmail.com> <1281991157-1557-4-git-send-email-netrolller.3d@gmail.com> <4C69A3E4.1080807@bu3sch.de> From: =?ISO-8859-1?Q?G=E1bor_Stefanik?= Date: Tue, 17 Aug 2010 08:37:51 +0200 Message-ID: Subject: Re: [PATCH 4/4] b43: N-PHY: Implement RX core state setting for rev.2 and earlier PHYs To: =?ISO-8859-1?Q?Michael_B=FCsch?= Cc: John Linville , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, Larry Finger , =?ISO-8859-2?Q?Rafa=B3_Mi=B3ecki?= Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Aug 16, 2010 at 10:47 PM, Michael B?sch wrote: > On 08/16/2010 10:39 PM, G?bor Stefanik wrote: >> >> +static void b43_nphy_set_rx_core_state(struct b43_wldev *dev, u8 mask) >> +{ >> + ? ? ? struct b43_phy *phy =&dev->phy; >> + ? ? ? struct b43_phy_n *nphy = phy->n; >> + ? ? ? u16 buf[16]; > >> + ? ? ? if (maskbits& ?0x3 != 0x3) { > > Does this even compile? I don't see maskbits being defined. Typo, should be just "mask" (without "bits"). > > -- > Greetings Michael. > -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)