Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:38742 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755173Ab0HCGkE (ORCPT ); Tue, 3 Aug 2010 02:40:04 -0400 Subject: Re: iwlwifi connection problems From: Johannes Berg To: Alex Romosan Cc: "Guy, Wey-Yi" , "linux-wireless@vger.kernel.org" In-Reply-To: <87aap4z70b.fsf@sycorax.lbl.gov> References: <87tynqvtu6.fsf@sycorax.lbl.gov> <1279917523.10769.1.camel@wwguy-huron> <1280135867.3693.5.camel@jlt3.sipsolutions.net> <87mxtd5xlq.fsf@sycorax.lbl.gov> <1280212629.19098.0.camel@jlt3.sipsolutions.net> <87bp9l6f4k.fsf@sycorax.lbl.gov> <1280746705.3923.11.camel@jlt3.sipsolutions.net> <878w4pvx5e.fsf@sycorax.lbl.gov> <1280766201.24503.0.camel@jlt3.sipsolutions.net> <87aap4z70b.fsf@sycorax.lbl.gov> Content-Type: text/plain; charset="UTF-8" Date: Tue, 03 Aug 2010 08:39:56 +0200 Message-ID: <1280817596.3874.0.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2010-08-02 at 20:53 -0700, Alex Romosan wrote: > Johannes Berg writes: > > > On Mon, 2010-08-02 at 08:42 -0700, Alex Romosan wrote: > > > >> so i think i finally managed to track this down. doing a git bisect i > >> get: > >> > >> 3474ad635db371b0d8d0ee40086f15d223d5b6a4 is the first bad commit > >> commit 3474ad635db371b0d8d0ee40086f15d223d5b6a4 > >> Author: Johannes Berg > >> Date: Thu Apr 29 04:43:05 2010 -0700 > >> > >> iwlwifi: apply filter flags directly > > > >> ... > > > > Thanks. I'll take a closer look tomorrow, am about to leave for today. > > so i looked a little bit more at what happened. the only difference > between the non working and the working version is a call to > iwlcore_commit_rxon(priv) on line 1327 of iwl-core.c (the version in > 2.6.35). if i comment that line out then i can connect to the access > point without problems. hope this helps. Yes, thank you, but it's very strange. But it's probably ok, let's remove the call then, it wasn't there before. Want to post a patch yourself? johannes