Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:65428 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753402Ab0IOQkD (ORCPT ); Wed, 15 Sep 2010 12:40:03 -0400 Date: Wed, 15 Sep 2010 09:39:39 -0700 From: Tony Lindgren To: Vitaly Wool Cc: Ohad Ben-Cohen , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Kalle Valo , Russell King - ARM Linux , akpm@linux-foundation.org, Nicolas Pitre , linux-mmc@vger.kernel.org, Mark Brown , linux-wireless@vger.kernel.org, San Mehat , Roger Quadros , Chikkature Rajashekar Madhusudhan , Luciano Coelho , linux-omap@vger.kernel.org, Ido Yariv , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 3/7] wireless: wl12xx: add platform data passing support Message-ID: <20100915163939.GU8647@atomide.com> References: <1283376410-9999-1-git-send-email-ohad@wizery.com> <1283376410-9999-4-git-send-email-ohad@wizery.com> <20100906120716.GE20903@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: * Vitaly Wool [100915 01:18]: > 2010/9/15 Ohad Ben-Cohen : > >> Sorry for pushing at this, but why would you mark data that's meant to > >> be used after init phase as __initdata? > > > > I can remove the first copying as well if Russell is ok with it. > > I personally think it's not worth it. This copying basically happens > only once and this point is soooo irrelevant. My position therefore > is: let's get the current implementation in, and if Michal is > uncomfortable with that, he can come up with the patch. Let's > concentrate on the real problems. This becomes an issue when compiling in support for multiple boards.. All the data that's not in use for the booted board should be __initdata. Regards, Tony