Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:54399 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768Ab0IFNqp (ORCPT ); Mon, 6 Sep 2010 09:46:45 -0400 MIME-Version: 1.0 In-Reply-To: <20100906120716.GE20903@n2100.arm.linux.org.uk> References: <1283376410-9999-1-git-send-email-ohad@wizery.com> <1283376410-9999-4-git-send-email-ohad@wizery.com> <20100906120716.GE20903@n2100.arm.linux.org.uk> From: Ohad Ben-Cohen Date: Mon, 6 Sep 2010 16:46:24 +0300 Message-ID: Subject: Re: [PATCH v5 3/7] wireless: wl12xx: add platform data passing support To: Russell King - ARM Linux Cc: =?ISO-8859-2?Q?Micha=B3_Miros=B3aw?= , linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, Kalle Valo , Nicolas Pitre , Tony Lindgren , Mark Brown , Roger Quadros , Ido Yariv , San Mehat , Chikkature Rajashekar Madhusudhan , Luciano Coelho , akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2010/9/6 Russell King - ARM Linux : > We could instead make wl12xx_get_platform_data() return a const pointer > to its own internal storage instead, or ERR pointers for the various > failure cases. Sounds good: diff --git a/drivers/net/wireless/wl12xx/wl12xx_platform_data.c b/drivers/net/wireless/wl12xx/wl12xx_platform_data.c new file mode 100644 index 0000000..973b110 --- /dev/null +++ b/drivers/net/wireless/wl12xx/wl12xx_platform_data.c @@ -0,0 +1,28 @@ +#include +#include +#include + +static const struct wl12xx_platform_data *platform_data; + +int __init wl12xx_set_platform_data(const struct wl12xx_platform_data *data) +{ + if (platform_data) + return -EBUSY; + if (!data) + return -EINVAL; + + platform_data = kmemdup(data, sizeof(*data), GFP_KERNEL); + if (!platform_data) + return -ENOMEM; + + return 0; +} + +const struct wl12xx_platform_data *wl12xx_get_platform_data(void) +{ + if (!platform_data) + return ERR_PTR(-ENODEV); + + return platform_data; +} +EXPORT_SYMBOL(wl12xx_get_platform_data); I'll wait a few days to see if there's any other comment, and then post v6 with this change. >