Subject: Re: [PATCH 16/25] wl1271: Add support for hardware GEM cipher
From: Johannes Berg <johannes@sipsolutions.net>
To: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Cc: "Coelho Luciano (Nokia-MS/Helsinki)" <Luciano.Coelho@nokia.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
In-Reply-To: <1285580806.11177.65.camel@wimaxnb.nmp.nokia.com>
References: <1285576669-8070-1-git-send-email-luciano.coelho@nokia.com>
	 <1285576669-8070-17-git-send-email-luciano.coelho@nokia.com>
	 <1285578777.4043.6.camel@jlt3.sipsolutions.net>
	 <1285580806.11177.65.camel@wimaxnb.nmp.nokia.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 27 Sep 2010 11:49:55 +0200
Message-ID: <1285580995.4043.7.camel@jlt3.sipsolutions.net>
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Mon, 2010-09-27 at 12:46 +0300, Juuso Oikarinen wrote:

> > > +#define WL1271_CIPHER_SUITE_GEM 0x000FACFF
> > 
> > NACK, this is a standards-reserved value. Use the correct ID for it or
> > allocate one within your own OUI if you don't want to admit what this
> > really is (and by now all readers here will know anyway.)
> 
> Well I'm sure many or most know what this patch is about. The choice of
> value was not intended to hide that.
> 
> You're right though, we'll need to change the OUI of the value, unless
> you can point me to an official value to use.

Well, ISO/IEC JTC 1 N 9880 says you should use 00-14-72:1.

johannes