Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:41081 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213Ab0INGJ4 (ORCPT ); Tue, 14 Sep 2010 02:09:56 -0400 Date: Tue, 14 Sep 2010 06:09:48 +0000 From: Jarek Poplawski To: Johannes Berg Cc: Felipe Contreras , linux-kernel@vger.kernel.org, Jiri Kosina , "John W. Linville" , "David S. Miller" , Kalle Valo , Felix Fietkau , Jouni Malinen , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/2] mac80211: fix compilation warning Message-ID: <20100914060948.GA6908@ff.dom.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1284441432.3704.0.camel@jlt3.sipsolutions.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2010-09-14 07:17, Johannes Berg wrote: > On Sun, 2010-09-12 at 14:10 +0300, Felipe Contreras wrote: > >> struct ieee80211_hdr hdr; >> - struct ieee80211s_hdr mesh_hdr; >> const u8 *encaps_data; >> int encaps_len, skip_header_bytes; >> int nh_pos, h_pos; >> @@ -1755,7 +1754,9 @@ netdev_tx_t ieee80211_subif_start_xmit(struct sk_buff *skb, >> hdrlen = 30; >> break; >> #ifdef CONFIG_MAC80211_MESH >> - case NL80211_IFTYPE_MESH_POINT: >> + case NL80211_IFTYPE_MESH_POINT: { >> + struct ieee80211s_hdr mesh_hdr; >> + > > ... > > might be nicer to just add __maybe_unused. > > johannes > Or at least more consistent with the fix in net-next ;-) Jarek P.