Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:33803 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168Ab0IICQc convert rfc822-to-8bit (ORCPT ); Wed, 8 Sep 2010 22:16:32 -0400 Received: by bwz11 with SMTP id 11so727949bwz.19 for ; Wed, 08 Sep 2010 19:16:31 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1283988329-44549-8-git-send-email-steve@cozybit.com> References: <1283988329-44549-1-git-send-email-steve@cozybit.com> <1283988329-44549-8-git-send-email-steve@cozybit.com> From: Julian Calaby Date: Thu, 9 Sep 2010 12:16:11 +1000 Message-ID: Subject: Re: [PATCH 7/9] libertas_tf: Add tx feedback to libertas_tf_sdio To: Steve deRosier Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com, johannes@sipsolutions.net, javier@cozybit.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: More nits: On Thu, Sep 9, 2010 at 09:25, Steve deRosier wrote: > This patch adds tx-feedback to libertas_tf_sdio so that mac80211 rate > adaptation and other bookkeeping tasks function properly. > > Signed-off-by: Steve deRosier > --- > ?drivers/net/wireless/libertas_tf/deb_defs.h | ? ?5 ++ > ?drivers/net/wireless/libertas_tf/if_sdio.c ?| ? 42 +++++++++++------ > ?drivers/net/wireless/libertas_tf/main.c ? ? | ? 65 ++++++++++++++++---------- > ?3 files changed, 72 insertions(+), 40 deletions(-) > > diff --git a/drivers/net/wireless/libertas_tf/deb_defs.h b/drivers/net/wireless/libertas_tf/deb_defs.h > index 99a7478..8e86e11 100644 > --- a/drivers/net/wireless/libertas_tf/deb_defs.h > +++ b/drivers/net/wireless/libertas_tf/deb_defs.h > @@ -1063,25 +1077,23 @@ static void if_sdio_interrupt(struct sdio_func *func) > ? ? ? ?if (ret) > ? ? ? ? ? ? ? ?goto out; > > -// ? ? lbtf_deb_sdio("interrupt: 0x%X\n", (unsigned)cause); > - > ? ? ? ?sdio_writeb(card->func, ~cause, IF_SDIO_H_INT_STATUS, &ret); > ? ? ? ?if (ret) > ? ? ? ? ? ? ? ?goto out; Shouldn't this have been removed instead of being commented in the patch that commented it? Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/