Return-path: Received: from nbd.name ([88.198.39.176]:41683 "EHLO ds10.nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754448Ab0IYJO0 (ORCPT ); Sat, 25 Sep 2010 05:14:26 -0400 Message-ID: <4C9DBD69.2070700@openwrt.org> Date: Sat, 25 Sep 2010 11:14:17 +0200 From: Felix Fietkau MIME-Version: 1.0 To: Ben Greear CC: Nick Kossifidis , linux-wireless@vger.kernel.org Subject: Re: [PATCH v2] This allows ath5k to support virtual STA and AP interfaces. References: <1285272430-9617-1-git-send-email-greearb@candelatech.com> <4C9CEB3F.5090804@candelatech.com> In-Reply-To: <4C9CEB3F.5090804@candelatech.com> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2010-09-24 8:17 PM, Ben Greear wrote: > On 09/24/2010 10:46 AM, Nick Kossifidis wrote: >> 2010/9/23: >>> From: Ben Greear >>> >>> +#define ATH5K_VIF_MAX 2048 >> >> This is too much !!! 2048 interfaces with a total of 4 beacon buffers >> 40 rx buffers and 200 tx buffers ? Has anyone tested this ? >> >> Also think about embedded devices, we don't want to waste memory like this... >> >>> + struct ieee80211_vif *vifs[ATH5K_VIF_MAX]; > > It only costs 4 or 8 bytes per pointer as long as no one actually > adds the vifs. > > We've tested at least 128 on an old 1Ghz VIA system, and I'd hope for more > on more modern hardware. I didn't think the driver should make the decision > to limit un-necessarily. > > If you still think this is too much, then tell me the biggest number > you wouldn't complain about :) Actually, looking at the code, I don't see much reason to even have this array. Most of the time the code is iterating over the list anyway, so we might as well just have a linked list here... That way we can avoid introducing bogus limitations or memory waste. - Felix