Return-path: Received: from smtp.nokia.com ([147.243.1.47]:61311 "EHLO mgw-sa01.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752309Ab0IPUCF (ORCPT ); Thu, 16 Sep 2010 16:02:05 -0400 Subject: Re: [PATCH v6 01/17] wl12xx: make wl12xx.h common to both spi and sdio From: Luciano Coelho To: ext Ohad Ben-Cohen Cc: "linux-wireless@vger.kernel.org" , "linux-omap@vger.kernel.org" , "John W. Linville" , Mark Brown , "linux-arm-kernel@lists.infradead.org" , Chikkature Rajashekar Madhusudhan , San Mehat , "Quadros Roger (Nokia-MS/Helsinki)" , Tony Lindgren , Nicolas Pitre , Ido Yariv , Kalle Valo , Russell King , Vitaly Wool , "Paasikivi Teemu.3 (EXT-Ixonos/Tampere)" In-Reply-To: References: <1284635762-12335-1-git-send-email-ohad@wizery.com> <1284662139.8951.7.camel@powerslave> Content-Type: text/plain; charset="UTF-8" Date: Thu, 16 Sep 2010 23:00:59 +0300 Message-ID: <1284667259.8951.75.camel@powerslave> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2010-09-16 at 21:56 +0200, ext Ohad Ben-Cohen wrote: > On Thu, Sep 16, 2010 at 8:35 PM, Luciano Coelho > wrote: > > Acked-by: Luciano Coelho > > > > I just wonder why the wl12xx.h move wasn't detected as a rename. Did > > you forget to use the -M option in format-patch? > > I thought it's because I stripped the SPI_ from the > #ifndef _LINUX_SPI_WL12XX_H, but it should be smarter than that. > Probably the -M. Yes, it is smarter than that. With small changes like this, -M will still show it as a rename and show the diff instead of the whole file -ed and +ed back ;) -- Cheers, Luca.