Return-path: Received: from mail-qy0-f181.google.com ([209.85.216.181]:33172 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755324Ab0JKQ61 convert rfc822-to-8bit (ORCPT ); Mon, 11 Oct 2010 12:58:27 -0400 Received: by qyk10 with SMTP id 10so4517542qyk.19 for ; Mon, 11 Oct 2010 09:58:26 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1286810435-10820-1-git-send-email-zajec5@gmail.com> <1286810435-10820-3-git-send-email-zajec5@gmail.com> From: =?ISO-8859-1?Q?G=E1bor_Stefanik?= Date: Mon, 11 Oct 2010 18:58:05 +0200 Message-ID: Subject: Re: [PATCH 3/3] b43: N-PHY: add 2055 radio regs To: =?ISO-8859-2?Q?Rafa=B3_Mi=B3ecki?= Cc: linux-wireless@vger.kernel.org, "John W. Linville" , b43-dev@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-2 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2010/10/11 Rafa? Mi?ecki : > W dniu 11 pa?dziernika 2010 18:24 u?ytkownik G?bor Stefanik > napisa?: >> Doesn't brcm80211 contain register names for B2055? > > Whoops... first of all it's 2056 radio. Commit's message should be > 2056, not 2055. > > Yes, I'm sure we can grab many defines from brcm80211. However before > copying their code/defines I wanted to finish implementing what we > have in our RE specs. Is that acceptable? Or should I use brcm80211's > names if I already touch such places? I don't know, Michael is the one to decide on this; but in general, it's bad practice to use magic numbers. > > -- > Rafa? > -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)