Return-path: Received: from mail.candelatech.com ([208.74.158.172]:34154 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753937Ab0JHRZd (ORCPT ); Fri, 8 Oct 2010 13:25:33 -0400 Message-ID: <4CAF53E2.8030306@candelatech.com> Date: Fri, 08 Oct 2010 10:24:50 -0700 From: Ben Greear MIME-Version: 1.0 To: Johannes Berg CC: "Luis R. Rodriguez" , "Luis R. Rodriguez" , ath9k , linux-wireless Subject: Re: [ath9k-devel] trying to set tx power (using txpower option) References: <20101008111221.5425.qmail@stuge.se> <4CAF4B70.9050001@candelatech.com> <20101008165232.GI10149@tux> <4CAF4FDA.8060908@candelatech.com> <1286557944.3612.5.camel@jlt3.sipsolutions.net> In-Reply-To: <1286557944.3612.5.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 10/08/2010 10:12 AM, Johannes Berg wrote: > On Fri, 2010-10-08 at 10:07 -0700, Ben Greear wrote: > >> Well, the command fails because of this check (mbm is 20 in his case) >> cfg.c: >> case NL80211_TX_POWER_FIXED: >> if (mbm< 0 || (mbm % 100)) >> return -EOPNOTSUPP; >> >> That mbm % 100 looks quite strange to me..any idea what that is supposed to >> accomplish? > > There's a later division by 100 to go from mBm to dBm ... I think you > want 2000, not 20. Well, it's documented in iw to be 'mBm', though I surely wouldn't have known what that stood for (nothing useful shows up on google for 'mBm units'). Thanks, Ben > > johannes -- Ben Greear Candela Technologies Inc http://www.candelatech.com