Return-path: Received: from mail.atheros.com ([12.19.149.2]:55246 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756508Ab0JYQ24 (ORCPT ); Mon, 25 Oct 2010 12:28:56 -0400 Received: from mail.atheros.com ([10.10.20.105]) by sidewinder.atheros.com for ; Mon, 25 Oct 2010 09:28:45 -0700 Date: Mon, 25 Oct 2010 09:28:54 -0700 From: "Luis R. Rodriguez" To: Mohammed Shajakhan CC: "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , Luis Rodriguez , "j@w1.fi" , Senthilkumar Balasubramanian , Vasanth Thiagarajan , "nbd@openwrt.org" Subject: Re: [PATCH] ath9k: Properly assign boolean types Signed-off-by: Mohammed Shafi Shajakhan Message-ID: <20101025162854.GA1970@tux> References: <1287990961-2619-1-git-send-email-mshajakhan@atheros.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <1287990961-2619-1-git-send-email-mshajakhan@atheros.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Oct 25, 2010 at 12:16:01AM -0700, Mohammed Shajakhan wrote: > From: Mohammed Shafi Shajakhan Your SOB is missing, and you put it on the subject Luis > > --- > drivers/net/wireless/ath/ath9k/rc.c | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c > index 0cee90c..0c70839 100644 > --- a/drivers/net/wireless/ath/ath9k/rc.c > +++ b/drivers/net/wireless/ath/ath9k/rc.c > @@ -1444,12 +1444,15 @@ static void ath_rate_init(void *priv, struct ieee80211_supported_band *sband, > ath_rc_priv->neg_ht_rates.rs_nrates = j; > } > > - is_cw40 = sta->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40; > + is_cw40 = (sta->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40) ? > + true : false; > > if (is_cw40) > - is_sgi = sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_40; > + is_sgi = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_40) ? > + true : false; > else if (sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_SGI_20) > - is_sgi = sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_20; > + is_sgi = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_20) ? > + true : false > > /* Choose rate table first */ > > -- > 1.7.0.4 >