Return-path: Received: from smtp.nokia.com ([192.100.122.230]:42151 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752519Ab0JYNLw (ORCPT ); Mon, 25 Oct 2010 09:11:52 -0400 Subject: Re: [PATCH] wireless/wl1271: remove redundant if-statement From: Luciano Coelho To: Nicolas Kaiser Cc: "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Larry Finger In-Reply-To: <4CC4B210.2010608@lwfinger.net> References: <20101025000744.17f7086e@absol.kitzblitz> <4CC4B210.2010608@lwfinger.net> Content-Type: text/plain; charset="UTF-8" Date: Mon, 25 Oct 2010 16:10:45 +0300 Message-ID: <1288012245.21130.24.camel@chilepepper> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2010-10-25 at 00:24 +0200, ext Larry Finger wrote: > On 10/24/2010 05:07 PM, Nicolas Kaiser wrote: > > Apparently the return value of wl1271_ps_elp_sleep never gets > > checked anyway. > > The patch is fine, but this comment is a little misleading as > wl1271_ps_elp_sleep() is void and cannot return a value. Yes, this patch is good, but please rewrite the description, as Larry suggested. -- Cheers, Luca.