Return-path: Received: from mga03.intel.com ([143.182.124.21]:22502 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759083Ab0JFRth (ORCPT ); Wed, 6 Oct 2010 13:49:37 -0400 Subject: Re: [PATCH wireless-2.6 or stable] iwlwifi: return error when fail to start scanning From: "Guy, Wey-Yi" To: Florian Mickler , Stanislaw Gruszka Cc: "linville@tuxdriver.com" , "stable@kernel.org" , "linux-wireless@vger.kernel.org" , "Chatre, Reinette" , "ilw@linux.intel.com" , "Berg, Johannes" , "Cahill, Ben M" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" In-Reply-To: <20101006194537.35e8b00e@schatten.dmk.lab> References: <20101005085717.GA18012@redhat.com> <1286317292-10679-1-git-send-email-florian@mickler.org> <20101006090228.GA2523@redhat.com> <20101006160434.GB24581@redhat.com> <20101006194537.35e8b00e@schatten.dmk.lab> Content-Type: text/plain Date: Wed, 06 Oct 2010 10:48:49 -0700 Message-Id: <1286387329.12594.21.camel@wwguy-ubuntu> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2010-10-06 at 10:45 -0700, Florian Mickler wrote: > Hi Stanislaw! > > On Wed, 6 Oct 2010 18:04:35 +0200 > Stanislaw Gruszka wrote: > > > This is stable friendly backport of wireless-testing commit > > 3eecce527c7434dfd16517ce08b49632c8a26717 "iwlwifi: unify scan start > > checks". Wireless-testing version include also a lot of cleanups. > > > > On error case in {iwl3945,iwlagn}_request_scan we queue abort_scan work, > > which in a fact do nothing, so we never complete the scan. Thats gives > > "WARNING: at net/wireless/core.c:614 wdev_cleanup_work" and stopped > > network connection until reload iwlwifi modules. Return of -EIO and > > stopping queuing any work is a fix. > > > > Note there are still many cases when we can get: > > > > WARNING: at net/wireless/core.c:614 wdev_cleanup_work > > WARNING: at net/mac80211/scan.c:266 ieee80211_scan_completed > > WARNING: at net/mac80211/scan.c:269 ieee80211_scan_complete > > > > which are not fixed. Unfortunately does not exist single, small fix > > for that problems, and we probably will see some more bug reports > > with scan warnings. As solution we rewrite iwl-scan.c code to avoid > > all possible race conditions. That quite big patch set is queued > > for 2.6.37 . > > > > Signed-off-by: Stanislaw Gruszka Signed-off-by: Wey-Yi Guy looks good to me Thanks Wey