Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:61643 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753129Ab0JNRGD convert rfc822-to-8bit (ORCPT ); Thu, 14 Oct 2010 13:06:03 -0400 Received: by ewy20 with SMTP id 20so3641808ewy.19 for ; Thu, 14 Oct 2010 10:06:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20101014165111.GA22130@suse.de> References: <20101014165111.GA22130@suse.de> Date: Thu, 14 Oct 2010 19:06:00 +0200 Message-ID: Subject: Re: Licensing wlc_phy_radio.h and brcm80211 (was: [PATCH 3/3] b43: N-PHY: add 2055 radio regs) From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Greg KH Cc: =?UTF-8?Q?G=C3=A1bor_Stefanik?= , "John W. Linville" , b43-dev , linux-wireless@vger.kernel.org, Henry Ptasinski , Brett Rudley , Nohee Ko Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2010/10/14 Greg KH : > On Thu, Oct 14, 2010 at 06:40:14PM +0200, Rafał Miłecki wrote: >> W dniu 11 października 2010 18:24 użytkownik Gábor Stefanik >> napisał: >> > Doesn't brcm80211 contain register names for B2055? >> >> I've checked brcm80211 and noticed defines in >> drivers/staging/brcm80211/phy/wlc_phy_radio.h. >> >> Whole brcm80211 driver is licensed as: >> MODULE_LICENSE("Dual BSD/GPL"); >> >> Mentioned file contains following comments: >> +/* >> + * Copyright (c) 2010 Broadcom Corporation >> + * >> + * Permission to use, copy, modify, and/or distribute this software for any >> + * purpose with or without fee is hereby granted, provided that the above >> + * copyright notice and this permission notice appear in all copies. >> >> Our b43 driver is licensed as: >> MODULE_LICENSE("GPL"); >> and I am not sure if permission above is actually GPL-compatible. The >> best option would be to add defines from wlc_phy_radio.h and include >> Broadcom's copyright. However comment above wants us to include info >> about free copying/modifying/using which is not GPL-compatible. >> >> Is there any way to solve this issue? > > I don't understand, are you just wanting to use the names in the .h file > for the registers? Yes. I want to put lines like: #define RADIO_2056_RX0 (0x6 << 12) in my radio_2056.h > If so, why?  You don't want to support the same devices in the b43 > driver that the brcm80211 driver does, do you? I do. I see many advantages of that plus most of the code is already here coming from RE. Finishing N-PHY support in b43 does not need much work plus: 1) We support SSB devices 2) We support older (LP/G-phy) devices 3) We share infrastructure (easier to maintain) 4) We probably could support modes like AP -- Rafał