Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:53795 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751944Ab0J0LjM (ORCPT ); Wed, 27 Oct 2010 07:39:12 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 27 Oct 2010 13:39:10 +0200 Message-ID: Subject: Re: drivers/platform/x86: Backlight-Add-backlight-type-v2.patch From: Corentin Chary To: sedat.dilek@gmail.com Cc: LKML , platform-driver-x86@vger.kernel.org, DRI , Matthew Garrett , acpi4asus-user@lists.sourceforge.net, =?UTF-8?Q?Michel_D=C3=A4nzer?= , linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Oct 27, 2010 at 1:06 PM, Sedat Dilek wrote: > Hi, > > while testing linux-next I wanted to reactivate the backlight type > patches laying in my build-dir. > > Within 2.6.36-rcX cycle I had successfully tested the backlight type > patch [1] with an additional patch for radeon by Michel (posted to > dri-devel ML, see [2]). > > The main patch needs a little refreshing. > > v2: drivers/platform/x86/asus-laptop.c: Refreshed to fit linux-next > (next-20101027) > > > Kind Regards, > - Sedat - > > [1] https://patchwork.kernel.org/patch/163971/ > [2] https://patchwork.kernel.org/patch/182352/ > Hi, I think rfkill has the same problem, on some platforms, the platform driver will add a rfkill switch, but the network (wlan/wimax/whatever) driver may also add one. AFAIK, the platform one is more likely to be able to power down the device completly. For the current patch, a common pattern seems to be : video/ -> RAW, platform/ -> PLATFORM. Couldn't we make some guess by checking the parent of the backlight instead of doing this by hand for every drivers ? Thanks, -- Corentin Chary http://xf.iksaif.net