Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:44082 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753731Ab0JYQuI (ORCPT ); Mon, 25 Oct 2010 12:50:08 -0400 Received: by iwn10 with SMTP id 10so1035498iwn.19 for ; Mon, 25 Oct 2010 09:50:07 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1287857641-7882-1-git-send-email-hauke@hauke-m.de> <4CC48B84.1000506@hauke-m.de> From: "Luis R. Rodriguez" Date: Mon, 25 Oct 2010 09:49:46 -0700 Message-ID: Subject: Re: [PATCH 1/3] compat: fix device_lock functions on non rt kernel To: Blaise Gassend Cc: Hauke Mehrtens , linux-wireless@vger.kernel.org, mcgrof@infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, Oct 24, 2010 at 1:41 PM, Blaise Gassend wrote: > Hi Hauke, > >> in the Ubuntu 10.04 default kernel config CONFIG_PREEMPT_VOLUNTARY=y is >> set, but it does not use the RT patches, so compat-wireless build >> failed. If you are using a mainline kernel you can choose between >> CONFIG_PREEMPT_NONE, CONFIG_PREEMPT_VOLUNTARY and CONFIG_PREEMPT (all >> localed in kernel/Kconfig.preempt for a least kernel 2.6.24), so these >> options are not indicating that the RT patches are applied. The RT patch >> adds CONFIG_PREEMPT_RT and CONFIG_PREEMPT_DESKTOP and removes >> CONFIG_PREEMPT, so choosing one of these options to detect that the RT >> patch is applied is not a good idea. I do not had the time to look >> through the hole rt patch to find a better indicator if it is applied so >> I just removed the ones preventing compiling on normal kernels. I just >> looked into patch-2.6.33.7-rt29.bz2 and not the other RT patches. > > OK, I see your point now. I did not realize that the mainstream > kernels also had those two options in them. I haven't had much luck > finding an config option that is always on in the RT kernels. For now > your fix sounds like the right tradeoff. Just so we're clear, no further patch is needed ay? Luis