Return-path: Received: from nbd.name ([88.198.39.176]:44294 "EHLO ds10.nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758772Ab0J1Xp7 (ORCPT ); Thu, 28 Oct 2010 19:45:59 -0400 Message-ID: <4CCA0B26.5010008@openwrt.org> Date: Fri, 29 Oct 2010 01:45:42 +0200 From: Felix Fietkau MIME-Version: 1.0 To: Ben Greear CC: =?ISO-8859-1?Q?Bj=F6rn_Smedman?= , "John W. Linville" , "Luis R. Rodriguez" , "ath9k-devel@venema.h4ckr.net" , linux-wireless Subject: Re: [ath9k-devel] [RFC] ath9k: Insert wmb before linking dma descriptors References: <20101005131744.GB4074@tuxdriver.com> <20101005195039.GD11831@tux> <4CB0890D.3050208@openwrt.org> <4CCA0908.6000105@candelatech.com> In-Reply-To: <4CCA0908.6000105@candelatech.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2010-10-29 1:36 AM, Ben Greear wrote: > On 10/09/2010 08:23 AM, Felix Fietkau wrote: >> On 2010-10-09 5:19 PM, Bj?rn Smedman wrote: >>> On Tue, Oct 5, 2010 at 9:50 PM, Luis R. Rodriguez >>> wrote: >>>> Felix is more familiar with this area so I'll let him chime with >>>> his ACK/NACK. >>>> >>>> Luis >>> >>> So Felix, what do you think? I realize it may not be a common problem >>> on any currently popular platform, but don't you agree it is in >>> principle unsafe to write to the ds_link field of dma descriptors >>> without a guarantee that those writes will be performed in the >>> intended order? >> Haven't had time to review this in detail yet. I'll take another look at >> it later... > > Had a chance to look at it? I've been carrying this in my > tree and it hasn't caused any obvious problems, for what that's > worth... Not sure if the patch helps with anything, but I think it can go in... - Felix