Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:46903 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755661Ab0JOO3n convert rfc822-to-8bit (ORCPT ); Fri, 15 Oct 2010 10:29:43 -0400 Received: by qwa26 with SMTP id 26so400034qwa.19 for ; Fri, 15 Oct 2010 07:29:43 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1287090064-14607-1-git-send-email-zajec5@gmail.com> <1287090064-14607-2-git-send-email-zajec5@gmail.com> Date: Fri, 15 Oct 2010 16:29:42 +0200 Message-ID: Subject: Re: [PATCH 2/3] b43: N-PHY: define registers names for 2056 radio From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: =?UTF-8?Q?G=C3=A1bor_Stefanik?= Cc: linux-wireless@vger.kernel.org, "John W. Linville" , b43-dev@lists.infradead.org, Henry Ptasinski , Brett Rudley , Nohee Ko Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: W dniu 15 października 2010 16:15 użytkownik Gábor Stefanik napisał: > 2010/10/15 Rafał Miłecki : >> W dniu 15 października 2010 01:58 użytkownik Gábor Stefanik >> napisał: >>> 2010/10/14 Rafał Miłecki : >>>> Signed-off-by: Rafał Miłecki >>>> Cc: Henry Ptasinski >>>> Cc: Brett Rudley >>>> Cc: Nohee Ko >>>> --- >>>>  drivers/net/wireless/b43/radio_2056.h |  522 +++++++++++++++++++++++++++++++++ >>>>  1 files changed, 522 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/drivers/net/wireless/b43/radio_2056.h b/drivers/net/wireless/b43/radio_2056.h >>>> index 60341d7..462c9fd 100644 >>>> --- a/drivers/net/wireless/b43/radio_2056.h >>>> +++ b/drivers/net/wireless/b43/radio_2056.h >>>> @@ -4,6 +4,9 @@ >>>> >>>>   Copyright (c) 2010 Rafał Miłecki >>>> >>>> +  Some parts of the code in this file are derived from the brcm80211 >>>> +  driver  Copyright (c) 2010 Broadcom Corporation >>>> + >>>>   This program is free software; you can redistribute it and/or modify >>>>   it under the terms of the GNU General Public License as published by >>>>   the Free Software Foundation; either version 2 of the License, or >>>> @@ -28,6 +31,525 @@ >>>> >>>>  #include "tables_nphy.h" >>>> >>>> +#define RADIO_2056_SYN                         (0x0 << 12) >>>> +#define RADIO_2056_TX0                         (0x2 << 12) >>>> +#define RADIO_2056_TX1                         (0x3 << 12) >>> >>> Please use B2056_ as the prefix. See LP-PHY. >> >> What does it mean? This "B" prefix? > > AFAIK it is a contraction for BCM. (The actual radio is called > BCM2056.) However, LP-PHY already uses B2062_ and B2063_ as its radio > register prefixes, so it is a good idea to follow the convention here, > too. Thanks for explaining and generally keeping eye on my patches :) I'll send modified version. -- Rafał