Return-path: Received: from mail-gx0-f174.google.com ([209.85.161.174]:54309 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753439Ab0JRRbk convert rfc822-to-8bit (ORCPT ); Mon, 18 Oct 2010 13:31:40 -0400 Received: by gxk21 with SMTP id 21so157304gxk.19 for ; Mon, 18 Oct 2010 10:31:40 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <4CAE1DFB.303@candelatech.com> <1286479642.20974.32.camel@jlt3.sipsolutions.net> <4CB378CD.1080800@candelatech.com> <4CB3D598.7050904@candelatech.com> <4CB4AA89.1070009@candelatech.com> <20101013053141.GA15798@vasanth-laptop> <4CB5E0A8.5020502@candelatech.com> <4CB78870.8040207@candelatech.com> From: "Luis R. Rodriguez" Date: Mon, 18 Oct 2010 10:24:30 -0700 Message-ID: Subject: Re: memory clobber in rx path, maybe related to ath9k. To: =?UTF-8?Q?Bj=C3=B6rn_Smedman?= Cc: Ben Greear , "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2010/10/18 Björn Smedman : > 2010/10/15 Björn Smedman >> >> 2010/10/15 Ben Greear : >> > I tried the patch below, and it didn't seem to help.  Might even >> > have hurt..as it died on divide-by-zero error: >> >> Hmm, looks like the ani code got a zero listen time from the hw... >> That just might mean that the DMA actually hits one of these >> descriptors. :) > > Am I the only one worried about this? Leaving a DMA descriptor > pointing at memory which has been passed on to somebody else... To me > that's like pointing a loaded gun at someone (and it seems this > particular gun can go off a little haphazardly). > > Luis, given how hard it seems to be to get that locking and skb > shoveling right, are you sure you want to keep pointing that DMA > engine on innocent people's data? This is why this issue is of high priority to me. I no longer get the poison nor does Ben, the RX poison issue is resolved as far as I can tell, I just need to split up the patches into easily reviewable chunks and get them upstream. Luis