Return-path: Received: from perninha.conectiva.com.br ([187.115.55.249]:35175 "EHLO perninha.conectiva.com.br" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753073Ab0KCN2p convert rfc822-to-8bit (ORCPT ); Wed, 3 Nov 2010 09:28:45 -0400 Date: Wed, 3 Nov 2010 11:28:43 -0200 From: Herton Ronaldo Krzesinski To: Rogerio Luz Coelho Cc: Thadeu Lima de Souza Cascardo , linux-wireless@vger.kernel.org Subject: Re: [PATCH 3/9] rtl8187: fix wrong register initialization in 8187B Message-ID: <20101103112843.15e51de7@gotham.conectiva> In-Reply-To: References: <309278.75116.qm@web29520.mail.ird.yahoo.com> <4CCF7B73.7040906@lwfinger.net> <4CCF7EFC.1050000@mandriva.com.br> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2 Nov 2010 21:48:20 -0200 Rogerio Luz Coelho wrote: > Ok, I see the 8187b is in development. > > But PLEASE ask Thadeu Cascardo for his patch as it seems to fix the > issue with these cards when connected to Laptop (Positivo Laptops in > Brasil for instance), this would even let the Mandriva folks show > Positivo that they don't need to ship the Mandriva 2008.0 woith their > Linux Laptops anymore ... He already reposted the patch and this series is based on top of it, so soon we should see it applied I guess. > > the patch he sent me FIXED the problem where the chip did not connect > or when it did it would lose the connection right away... > > see > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/215802?comments=all > > > I haven´t aplied any other patches and the one he sent me JUST WORKS, > tested in a Ubuntu 10.04 64bit (64bit being important since the > Realtek support told me they did NOT support 64bit with their linux > drivers) Note that this series don't replace patch from Thadeu, it's just more cleanups and fixes. > > Thanks > > Rogerio > > 2010/11/2 Herton Ronaldo Krzesinski : > > On 02-11-2010 00:46, Larry Finger wrote: > >> > >> On 11/01/2010 09:42 PM, Hin-Tak Leung wrote: > >>> > >>> --- On Tue, 2/11/10, Herton Ronaldo Krzesinski > >>>  wrote: > >>> > >>>> We were using wrong address for BRSR > >>>> (Basic Rate Set Register) while > >>>> initializing its value, comparing with Realtek sources, for > >>>> 8187B case. > >>>> > >>>> Also, the same register is initialized in > >>>> rtl8187b_reg_table, so remove > >>>> the duplicate initialization from the table. > >>>> > >>>> Signed-off-by: Herton Ronaldo Krzesinski > >>>> Acked-by: Larry Finger > >>> > >>> Acked-by: Hin-Tak Leung > >>> > >>> ANAPARAM* stands for "anonymous parameters", right?  One of these days we > >>> should give them some meaningful names. > >> > >> I have always thought it was for "analog parameter". Am I wrong? > > > > Nope, you're right, its listed description is "analog parameter" in 8180 > > spec. > > > >> > >> Larry > > > > -- > > []'s > > Herton > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at  http://vger.kernel.org/majordomo-info.html > > -- []'s Herton