Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:36025 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753474Ab0K2Mle (ORCPT ); Mon, 29 Nov 2010 07:41:34 -0500 Message-ID: <4CF39F79.7070306@ti.com> Date: Mon, 29 Nov 2010 14:41:29 +0200 From: Gery Kahn Reply-To: geryk@ti.com MIME-Version: 1.0 To: Luciano Coelho CC: =?ISO-8859-1?Q?ext_G=E1bor_Stefanik?= , "juuso.oikarinen@nokia.com" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH] wl12xx: Remove 11j channels from the supported channels list. References: <1291025153-17570-1-git-send-email-juuso.oikarinen@nokia.com> <1291033587.1673.39.camel@powerslave> In-Reply-To: <1291033587.1673.39.camel@powerslave> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/29/2010 02:26 PM, Luciano Coelho wrote: > On Mon, 2010-11-29 at 13:06 +0100, ext G?bor Stefanik wrote: >> On Mon, Nov 29, 2010 at 11:05 AM, wrote: >>> From: Juuso Oikarinen >>> >>> Because we don't support them at this stage. >>> >>> Signed-off-by: Juuso Oikarinen >>> --- >>> drivers/net/wireless/wl12xx/main.c | 8 -------- >>> 1 files changed, 0 insertions(+), 8 deletions(-) >>> >>> diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c >>> index 7fecefe..dc3a093 100644 >>> --- a/drivers/net/wireless/wl12xx/main.c >>> +++ b/drivers/net/wireless/wl12xx/main.c >>> @@ -2374,14 +2374,6 @@ static struct ieee80211_rate wl1271_rates_5ghz[] = { >>> >>> /* 5 GHz band channels for WL1273 */ >>> static struct ieee80211_channel wl1271_channels_5ghz[] = { >> >> Is this for WL1271 or WL1273? The comment contradicts the name... > > The wl1273 chip supports 5GHz channels. The wl1271 chip doesn't. > > The driver supports both wl1271 and wl1273. We have even changed the > name to align with this (the driver is now called wl12xx). > > We changed the file names and the module names already, but we haven't > changed the function and structure names yet. At some point someone > will s/wl1271/wl12xx/. Yes, it is confusing as it is right now, so > hopefully the renaming will happen soon. Volunteers? ;) > is there enable_11a to use for?