MIME-Version: 1.0
In-Reply-To: <1289528843-21982-1-git-send-email-lrodriguez@atheros.com>
References: <1289528843-21982-1-git-send-email-lrodriguez@atheros.com>
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Date: Thu, 11 Nov 2010 18:45:11 -0800
Message-ID: <AANLkTik9w0_ZJJ273m7B30H4mUcaVeGVirOWAaMuPO-s@mail.gmail.com>
Subject: Re: [PATCH] cfg80211: Fix regulatory bug with multiple cards with a
 delayed CRDA response
To: linville@tuxdriver.com
Cc: mark@moxienet.com, linux-wireless@vger.kernel.org,
	"Luis R. Rodriguez" <lrodriguez@atheros.com>, stable@kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-wireless-owner@vger.kernel.org

On Thu, Nov 11, 2010 at 6:27 PM, Luis R. Rodriguez
<lrodriguez@atheros.com> wrote:
> When two cards are connected with the same regulatory domain
> if CRDA had a delayed response then cfg80211's own set regulatory
> domain would still be the world regulatory domain. There was a bug
> on cfg80211's ignore_request() when analyzing incoming driver
> regulatory hints as it was only checking against the currently
> set cfg80211 regulatory domain and not for any other new
> pending requests. This is easily fixed by also checking against
> the pending request.
>
> Without this fix the second card would end up with an intersected
> regulatory domain and now allow it to use the channels it really
> is designed for.
>
> This was reproduced and tested against mac80211_hwsim using this
> CRDA delayer:
>
>        #!/bin/bash
>        echo $COUNTRY >> /tmp/log
>        sleep 2
>        /sbin/crda.orig
>
> And this regulatory test:
>
>        modprobe mac80211_hwsim regtest=2
>
> This patch has fixes for cfg80211 all the way back.
>
> Reported-by: Mark Mentovai <mark@moxienet.com>
> Cc: stable@kernel.org
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>

Hrm,

modprobe mac80211_hwsim regtest=3

Does the similar test but using two different regulatory domains,
however this ends up slapping an intersection over to both. Going to
think this through a bit more.

  Luis