Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:34091 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751407Ab0KKP36 (ORCPT ); Thu, 11 Nov 2010 10:29:58 -0500 Date: Thu, 11 Nov 2010 10:28:18 -0500 From: "John W. Linville" To: Rajkumar Manoharan Cc: Christian Lamparter , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH] ath9k_htc: Add new devices into AR7010 Message-ID: <20101111152818.GA2559@tuxdriver.com> References: <1289389041-26938-1-git-send-email-rmanoharan@atheros.com> <20101110131356.GA27734@vmraj-lnx.users.atheros.com> <20101111132341.GA8029@vmraj-lnx.users.atheros.com> <201011111512.30343.chunkeey@googlemail.com> <44EE5C37ADC36343B0625A05DD408C4850DAB4D6CE@CHEXMB-01.global.atheros.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <44EE5C37ADC36343B0625A05DD408C4850DAB4D6CE@CHEXMB-01.global.atheros.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Nov 11, 2010 at 08:51:37PM +0530, Rajkumar Manoharan wrote: > >On Thursday 11 November 2010 14:23:41 Rajkumar Manoharan wrote: > >> On Wed, Nov 10, 2010 at 06:43:57PM +0530, Rajkumar Manoharan wrote: > > >> On Wed, Nov 10, 2010 at 06:05:14PM +0530, Christian Lamparter wrote: > > > >> On Wednesday 10 November 2010 12:37:21 Rajkumar Manoharan wrote: > > > > >> Treat PIDs (0xA704, 0x1200) as AR7010 devices. > > > >> > > > > >just a though, but instead of relying only on the pid and > >> > > hope for no collisions. you could put a @driver_info flag > >> > > for all AR7010 devices into the usb_device_id table and > > >> > remove the per-device "cases". > > > >> > >> > Make sense. Thanks for your review. I'll resend the patch. > >> > > >> After adding @driver_info to replace per-device cases, > >> the patch looks like cleanup one which is not compatible for stable kernel. > >> So let the previous patches to be integrated, due to minimal changes. > >> And I'll submit the cleanup patch separately. Is that fine? > >sure? > > > > Or is this a question directed to John? > > Both you and John. Since these patches are stable and enable support to new devices, > I prefer to go with minimal changes. I will submit the cleanup patches to wireless-testing. > > Any comments John? Sounds fine. -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.