Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:50187 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893Ab0KWUL7 convert rfc822-to-8bit (ORCPT ); Tue, 23 Nov 2010 15:11:59 -0500 Received: by wyb28 with SMTP id 28so8660025wyb.19 for ; Tue, 23 Nov 2010 12:11:57 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20101123192119.GP29396@tux> References: <20101123190359.GL4303@makis.mantri> <20101123192119.GP29396@tux> Date: Tue, 23 Nov 2010 22:11:57 +0200 Message-ID: Subject: Re: [ath5k-devel] [PATCH 12/30] ath5k: Increase PHY settling parameters for turo mode From: Nick Kossifidis To: "Luis R. Rodriguez" Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org, linville@tuxdriver.com, me@bobcopeland.com, mcgrof@gmail.com, jirislaby@gmail.com, nbd@openwrt.org, br1@einfach.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2010/11/23 Luis R. Rodriguez : > On Tue, Nov 23, 2010 at 11:04:43AM -0800, Nick Kossifidis wrote: > > Are you willing to deal with *all* bug reports for this? > >  Luis > I don't enable 5/10/40MHz operation anywhere for now, it's just there for testing/debug. I tested it and it seems to work fine (also with a spectrum analyzer) but until we come up with the proper way to set this from user-space I'll wait. Also have in mind I just do what Atheros does on initvals, nothing new, I just diffed initvals/rfbuffer settings between turbo/non-turbo modes, found what's changing and how (i had 5/10MHz code from HAL for that -as i wrote on another mail 5/10/40MHz work mostly the same way-) and implemented it on code. Now it's much cleaner + it actually works so i don't see a problem with that. Before we had code for turbo that didn't work and duplicated arrays of initvals/rfbuffer settings for no reason. Have in mind that there are people out there that want 5/10MHz support badly to implement 802.11p on top of it (or for research) and people who want to get rid of MadWiFi on OpenWRT and use turbo mode with ath5k. We had to do this sometime, it's not a dirty hack, i think the implementation is clean and simple. As for bug reports we already have bug reports about cards that fail to wake up that we are unable to debug because we have no idea what's going on, you can't choose what you 'll do based on possible bug reports, bugs are part of the process... -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick