Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:38242 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754305Ab0KKLGB convert rfc822-to-8bit (ORCPT ); Thu, 11 Nov 2010 06:06:01 -0500 Received: by qwi4 with SMTP id 4so1560022qwi.19 for ; Thu, 11 Nov 2010 03:06:00 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: Date: Thu, 11 Nov 2010 13:06:00 +0200 Message-ID: Subject: Re: wl1271 sdio timeouts on omap3 From: Grazvydas Ignotas To: Joerie de Gram Cc: Ohad Ben-Cohen , linux-wireless@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Nov 10, 2010 at 5:01 PM, Joerie de Gram wrote: > On Wed, Nov 10, 2010 at 6:35 AM, Ohad Ben-Cohen wrote: >> Snippets below are not complete. E.g., where do you actually indicate >> the gpio number ? >> It's better to send your complete patch so we can have a look. > > Sorry, I've attached a full diff of the board changes below. Your vsim configuration looks wrong. > > @@ -213,6 +224,16 @@ static struct regulator_consumer_supply > nowplus_vpll2_supply = { > ? ? ? ?.dev ? ? ? ? ? ? ? ? ? ?= &nowplus_dss_device.dev, > ?}; > > +static struct regulator_consumer_supply nowplus_vsim_supply = { > + ? ? ? .supply ? ? ? ? ? ? ? ? = "vmmc", > +}; You need to set .dev or .dev_name here, best just do + .dev_name = "mmci-omap-hs.2", > + > + > +static struct regulator_consumer_supply nowplus_wl1271_supply = { > + ? ? ? .supply ? ? ? ? ? ? ? ? = "vmmc_aux", > + ? ? ? .dev_name ? ? ? ? ? ? ? = "mmci-omap-hs.2", > +}; > + > ?/* VMMC1 for MMC1 card */ > ?static struct regulator_init_data nowplus_vmmc1 = { > ? ? ? ?.constraints = { > @@ -311,6 +332,53 @@ static struct regulator_init_data nowplus_vpll2 = { > ? ? ? ?.consumer_supplies ? ? ?= &nowplus_vpll2_supply, > ?}; > > +/* VSIM for WiFi SDIO */ > +static struct regulator_init_data nowplus_vsim = { doesn't seem to be referenced anywhere? You need to add it to twl4030_platform_data I think.