Return-path: Received: from smtp.nokia.com ([147.243.1.47]:43535 "EHLO mgw-sa01.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756754Ab0KBHe2 (ORCPT ); Tue, 2 Nov 2010 03:34:28 -0400 Subject: Re: [PATCH 2/2] wl1271: add recover testmode command From: Luciano Coelho To: ext Eliad Peller Cc: ext =?ISO-8859-1?Q?G=E1bor?= Stefanik , "linux-wireless@vger.kernel.org" In-Reply-To: References: <1288181398-2358-1-git-send-email-eliad@wizery.com> <1288181398-2358-2-git-send-email-eliad@wizery.com> <1288617893.20937.10.camel@chilepepper> <1288647745.21112.76.camel@powerslave> Content-Type: text/plain; charset="UTF-8" Date: Tue, 02 Nov 2010 09:34:25 +0200 Message-ID: <1288683265.28890.0.camel@chilepepper> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2010-11-02 at 08:05 +0100, ext Eliad Peller wrote: > On Mon, Nov 1, 2010 at 11:42 PM, Luciano Coelho > wrote: > > > > In any case, I'm not sure I really like this idea of a HW recovery test > > command. This should really be done automatically by the driver and, > > with Juuso's implementation plus the watchdog, we shouldn't really need > > it. > > > as i wrote before - it's mainly for testing purposes. > that's why adding it as a testcmd made sense to me (i guess we do want > some easy way to trigger and test the recovery sequence). Okay, so it's for testing the actual recovery sequence... That makes sense. I'll apply your patch. -- Cheers, Luca.