Return-path: Received: from mail-qy0-f181.google.com ([209.85.216.181]:49912 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753130Ab0KDVsr convert rfc822-to-8bit (ORCPT ); Thu, 4 Nov 2010 17:48:47 -0400 Received: by qyk10 with SMTP id 10so1874250qyk.19 for ; Thu, 04 Nov 2010 14:48:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1288891196.17643.6.camel@powerslave> References: <1288883257-30060-1-git-send-email-shahar_levi@ti.com> <1288891196.17643.6.camel@powerslave> From: =?ISO-8859-1?Q?G=E1bor_Stefanik?= Date: Thu, 4 Nov 2010 22:48:26 +0100 Message-ID: Subject: Re: [PATCH v4] wl1271: Change wl12xx Files Names To: Luciano Coelho Cc: ext Grazvydas Ignotas , Shahar Levi , "linux-wireless@vger.kernel.org" , Kalle Valo Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Nov 4, 2010 at 6:19 PM, Luciano Coelho wrote: > On Thu, 2010-11-04 at 17:37 +0100, ext Grazvydas Ignotas wrote: >> On Thu, Nov 4, 2010 at 5:07 PM, Shahar Levi wrote: >> > All files name prefix removed due to the fact that wl12xx driver supports >> > wl1271 and wl1273. >> > Also the definition in Kconfig and header files changed respectively. >> > >> > Signed-off-by: Shahar Levi >> >> Hmh the name 'wl12xx' kind of implies it covers 1251, while in fact >> wl1251 is completely separate driver.. At least the Kconfig help text >> should mention it doesn't cover wl1251 and users should use respective >> driver for wl1251. > > That's a good point. ?We have discussed this before and this was the > best solution we found. ?The wl12xx driver includes support for wl1271 > and wl1273, so we considered calling it wl127x, but in the near future, > we'll have support for wl1281 and wl1283 as well. ?So we have to use > wl12xx. > > At least in my opinion, it is kind of clear that if there is a separate > driver for wl1251, the user would use that one. ?In any case, A note in > the Kconfig help text would definitely not hurt. > > Shahar, could you please change the text in the Kconfig so that it reads > something like this? > > "This module adds support for wireless adapters based on TI wl1271 and > TI wl1273 chipsets. ?This module does *not* include support for wl1251. > For wl1251 support, use the separate homonymous driver instead." What about wl1251 vs. wl12agn (or wl12bgn if no .11a support), like iwlwifi? > > > -- > Cheers, > Luca. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at ?http://vger.kernel.org/majordomo-info.html > -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)