Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:49531 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754202Ab0KSS5Q (ORCPT ); Fri, 19 Nov 2010 13:57:16 -0500 Subject: Re: [PATCH v7 3/3] nl80211/mac80211: Report signal average From: Johannes Berg To: Jouni Malinen Cc: Bruno Randolf , linville@tuxdriver.com, randy.dunlap@oracle.com, br1@thinktube.com, peterz@infradead.org, blp@cs.stanford.edu, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Lars_Ericsson@telia.com, stefanr@s5r6.in-berlin.de, kosaki.motohiro@jp.fujitsu.com, akpm@linux-foundation.org, kevin.granade@gmail.com In-Reply-To: <20101116093743.GA21872@jm.kir.nu> References: <20101112024901.28522.21895.stgit@localhost6.localdomain6> <20101112030035.28522.75318.stgit@localhost6.localdomain6> <20101116093743.GA21872@jm.kir.nu> Content-Type: text/plain; charset="UTF-8" Date: Fri, 19 Nov 2010 10:58:36 -0800 Message-ID: <1290193116.3768.8.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2010-11-16 at 11:37 +0200, Jouni Malinen wrote: > On Fri, Nov 12, 2010 at 12:00:35PM +0900, Bruno Randolf wrote: > > Extend nl80211 to report an exponential weighted moving average (EWMA) of the > > signal value. Since the signal value usually fluctuates between different > > packets, an average can be more useful than the value of the last packet. > > > > This uses the recently added generic EWMA library function. > > Isn't that generic EWMA library function making this much more CPU > intensive than necessary? John, is there any reason you completely ignored Jouni's feedback here? This wasn't addressed in v8. johannes