Return-path: Received: from 80-190-117-144.ip-home.de ([80.190.117.144]:49980 "EHLO bu3sch.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934928Ab0KQRNC (ORCPT ); Wed, 17 Nov 2010 12:13:02 -0500 Subject: Re: [PATCH] ssb: fail registration for unknown SPROM revision From: Michael =?ISO-8859-1?Q?B=FCsch?= To: "John W. Linville" Cc: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org In-Reply-To: <20101116212321.GF10774@tuxdriver.com> (sfid-20101116_162951_428051_09CF3C97) References: <1288823326-9686-1-git-send-email-zajec5@gmail.com> <1288823326-9686-2-git-send-email-zajec5@gmail.com> <20101116212321.GF10774@tuxdriver.com> (sfid-20101116_162951_428051_09CF3C97) Content-Type: text/plain; charset="UTF-8" Date: Wed, 17 Nov 2010 18:12:56 +0100 Message-ID: <1290013976.2513.14.camel@maggie> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2010-11-16 at 16:23 -0500, John W. Linville wrote: > > - ssb_printk(KERN_WARNING PFX "Unsupported SPROM" > > - " revision %d detected. Will extract" > > - " v1\n", out->revision); > > - out->revision = 1; > > - sprom_extract_r123(out, in); > > + ssb_printk(KERN_ERR PFX "Unsupported SPROM revision %d" > > + " detected\n", out->revision); > > + return -EINVAL; > > } > > > > if (out->boardflags_lo == 0xFFFF) > > I think this is going to make my b43 PCI-E card not work...I'll try > it and get back to you... Hm, what version does it report? -- Greetings Michael.