Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:50682 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728Ab0LCPAL (ORCPT ); Fri, 3 Dec 2010 10:00:11 -0500 Date: Fri, 3 Dec 2010 09:56:55 -0500 From: "John W. Linville" To: "Luis R. Rodriguez" Cc: ath5k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org, me@bobcopeland.com, jirislaby@gmail.com, nbd@openwrt.org, br1@einfach.org, sedat.dilek@googlemail.com Subject: Re: [PATCH 5/6] ath5k: Update version string Message-ID: <20101203145654.GB2348@tuxdriver.com> References: <20101203041109.GE2988@makis.mantri> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Dec 02, 2010 at 08:17:41PM -0800, Luis R. Rodriguez wrote: > On Thu, Dec 2, 2010 at 8:11 PM, Nick Kossifidis wrote: > > ?* Change version number, we've added various new features lately. > > ?We need to find a way to maintain this, maybe on each kernel release > > ?or something. Also remove "EXPERIMENTAL", we aren't experimental any > > ?more I think ;-) > > > > ?Signed-off-by: Nick Kossifidis > > > +MODULE_VERSION("0.7.0"); > > How about just remove this all together, the version should go by the > kernel or git describe. ACK -- any objections? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.