Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:54921 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756466Ab0LATPh (ORCPT ); Wed, 1 Dec 2010 14:15:37 -0500 Received: by bwz15 with SMTP id 15so6435022bwz.19 for ; Wed, 01 Dec 2010 11:15:36 -0800 (PST) Message-ID: <4CF69ED1.1070406@lwfinger.net> Date: Wed, 01 Dec 2010 13:15:29 -0600 From: Larry Finger MIME-Version: 1.0 To: Michael Buesch , John Linville , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , =?UTF-8?B?R8OhYm9yIA==?= =?UTF-8?B?U3RlZmFuaWs=?= CC: b43-dev , wireless Subject: RFC - removal of SPROM fallback Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: At one time, we thought that we had found BCM43xx devices with no SPROM. In the one case that I remember, it was because the SPROM had been relocated. I now have the data from John's device that needs the revision fixup and I know what is wrong - it is rev 2 with corrupted CRC. The defaulting to rev 1 is getting almost everything wrong, including MAC address and vendor. My plan is to write a better fixup routine. At the moment, we have some SPROM fallback code that has not been fully implemented, and is probably not needed. Are there any objections to stripping this code out of drivers/ssb/pci.c and drivers/ssb/sprom.c? Larry