Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:47773 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753758Ab0LGPsM (ORCPT ); Tue, 7 Dec 2010 10:48:12 -0500 Subject: Re: [PATCH 5/5] mac80211: fix issuing idle calls when device open count is 0 From: Johannes Berg To: "Luis R. Rodriguez" Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, amod.bodas@atheros.com, pstew@google.com, stable@kernel.org In-Reply-To: References: <1291690135-4535-1-git-send-email-lrodriguez@atheros.com> <1291690135-4535-6-git-send-email-lrodriguez@atheros.com> <1291714709.3607.2.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Date: Tue, 07 Dec 2010 16:48:07 +0100 Message-ID: <1291736887.3607.47.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2010-12-07 at 07:44 -0800, Luis R. Rodriguez wrote: > >> drv_stop(local); > >> + ieee80211_recalc_idle_force(local); > > > > That one definitely can't be after drv_stop(). > > OK why though? Because you can't call into drivers after you stop them? Shouldn't this be obvious? johannes