Subject: Re: [PATCH v3 14/18] wl1271: AP mode - record TX configuration
 settings
From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Arik Nemtsov <arik@wizery.com>
Cc: linux-wireless@vger.kernel.org
In-Reply-To: <AANLkTi=tTx=XZ0nFnTsds1F1X2saSYiVmgSxWL1zU-GY@mail.gmail.com>
References: <1293557808-27068-1-git-send-email-arik@wizery.com>
	 <1293557808-27068-15-git-send-email-arik@wizery.com>
	 <1293614508.15791.0.camel@powerslave>
	 <AANLkTi=tTx=XZ0nFnTsds1F1X2saSYiVmgSxWL1zU-GY@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 30 Dec 2010 00:35:52 +0200
Message-ID: <1293662152.15791.4.camel@powerslave>
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Wed, 2010-12-29 at 23:11 +0200, ext Arik Nemtsov wrote:
> On Wed, Dec 29, 2010 at 11:21, Luciano Coelho <luciano.coelho@nokia.com> wrote:
> > On Tue, 2010-12-28 at 19:36 +0200, ext Arik Nemtsov wrote:
> >>
> >> diff --git a/drivers/net/wireless/wl12xx/main.c
> >> b/drivers/net/wireless/wl12xx/main.c
> >> index 3747d98..ea61ae7 100644
> >> --- a/drivers/net/wireless/wl12xx/main.c
> >> +++ b/drivers/net/wireless/wl12xx/main.c
> >> @@ -1433,6 +1433,8 @@ static int wl1271_op_config(struct ieee80211_hw
> >> *hw, u32 changed)
> >>                 goto out;
> >>         }
> >>
> >> +       is_ap = (wl->bss_type == BSS_TYPE_AP_BSS);
> >> +
> >>         ret = wl1271_ps_elp_wakeup(wl, false);
> >>         if (ret < 0)
> >>                 goto out;
> >
> > Did you forget to fix this one? As we discussed, this should be in
> > 10/18.
> >
> 
> Actually it was added in 10/18 (at the beginning of the function), but
> I forgot to remove it from 14/18.
> The correct place to set this is here after the mutex is held, so I've
> moved this line to 10/18 (for good this time I hope).

Yes, after I wrote this email, I checked 10/18 and it was there together
with the is_ap declaration, but, as you said, better do it after the
mutex is locked.

-- 
Cheers,
Luca.