Return-path: Received: from server19320154104.serverpool.info ([193.201.54.104]:53911 "EHLO hauke-m.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752881Ab0LGTIw (ORCPT ); Tue, 7 Dec 2010 14:08:52 -0500 Message-ID: <4CFE863A.30203@hauke-m.de> Date: Tue, 07 Dec 2010 20:08:42 +0100 From: Hauke Mehrtens MIME-Version: 1.0 To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= CC: linux-wireless@vger.kernel.org, "John W. Linville" , b43-dev@lists.infradead.org Subject: Re: [PATCH 1/4] b43: N-PHY: update init tables References: <1291711327-4690-1-git-send-email-zajec5@gmail.com> In-Reply-To: <1291711327-4690-1-git-send-email-zajec5@gmail.com> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 12/07/2010 09:42 AM, Rafał Miłecki wrote: > Signed-off-by: Rafał Miłecki > --- > drivers/net/wireless/b43/tables_nphy.c | 212 ++++++++++++++++---------------- > 1 files changed, 106 insertions(+), 106 deletions(-) > > diff --git a/drivers/net/wireless/b43/tables_nphy.c b/drivers/net/wireless/b43/tables_nphy.c > index d60db07..46f0a7a 100644 > --- a/drivers/net/wireless/b43/tables_nphy.c > +++ b/drivers/net/wireless/b43/tables_nphy.c > @@ -28,41 +28,41 @@ > #include "phy_n.h" > > static const u8 b43_ntab_adjustpower0[] = { > - 0x00, 0x00, 0x00, 0x00, 0x01, 0x01, 0x01, 0x01, > - 0x02, 0x02, 0x02, 0x02, 0x03, 0x03, 0x03, 0x03, > - 0x04, 0x04, 0x04, 0x04, 0x05, 0x05, 0x05, 0x05, > - 0x06, 0x06, 0x06, 0x06, 0x07, 0x07, 0x07, 0x07, > - 0x08, 0x08, 0x08, 0x08, 0x09, 0x09, 0x09, 0x09, > - 0x0A, 0x0A, 0x0A, 0x0A, 0x0B, 0x0B, 0x0B, 0x0B, > - 0x0C, 0x0C, 0x0C, 0x0C, 0x0D, 0x0D, 0x0D, 0x0D, > - 0x0E, 0x0E, 0x0E, 0x0E, 0x0F, 0x0F, 0x0F, 0x0F, > - 0x10, 0x10, 0x10, 0x10, 0x11, 0x11, 0x11, 0x11, > - 0x12, 0x12, 0x12, 0x12, 0x13, 0x13, 0x13, 0x13, > - 0x14, 0x14, 0x14, 0x14, 0x15, 0x15, 0x15, 0x15, > - 0x16, 0x16, 0x16, 0x16, 0x17, 0x17, 0x17, 0x17, > - 0x18, 0x18, 0x18, 0x18, 0x19, 0x19, 0x19, 0x19, > - 0x1A, 0x1A, 0x1A, 0x1A, 0x1B, 0x1B, 0x1B, 0x1B, > - 0x1C, 0x1C, 0x1C, 0x1C, 0x1D, 0x1D, 0x1D, 0x1D, > - 0x1E, 0x1E, 0x1E, 0x1E, 0x1F, 0x1F, 0x1F, 0x1F, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > }; Why do you have this table when it only contains 0x00? If it is correct there will be a better way to define such a table. > > static const u8 b43_ntab_adjustpower1[] = { > - 0x00, 0x00, 0x00, 0x00, 0x01, 0x01, 0x01, 0x01, > - 0x02, 0x02, 0x02, 0x02, 0x03, 0x03, 0x03, 0x03, > - 0x04, 0x04, 0x04, 0x04, 0x05, 0x05, 0x05, 0x05, > - 0x06, 0x06, 0x06, 0x06, 0x07, 0x07, 0x07, 0x07, > - 0x08, 0x08, 0x08, 0x08, 0x09, 0x09, 0x09, 0x09, > - 0x0A, 0x0A, 0x0A, 0x0A, 0x0B, 0x0B, 0x0B, 0x0B, > - 0x0C, 0x0C, 0x0C, 0x0C, 0x0D, 0x0D, 0x0D, 0x0D, > - 0x0E, 0x0E, 0x0E, 0x0E, 0x0F, 0x0F, 0x0F, 0x0F, > - 0x10, 0x10, 0x10, 0x10, 0x11, 0x11, 0x11, 0x11, > - 0x12, 0x12, 0x12, 0x12, 0x13, 0x13, 0x13, 0x13, > - 0x14, 0x14, 0x14, 0x14, 0x15, 0x15, 0x15, 0x15, > - 0x16, 0x16, 0x16, 0x16, 0x17, 0x17, 0x17, 0x17, > - 0x18, 0x18, 0x18, 0x18, 0x19, 0x19, 0x19, 0x19, > - 0x1A, 0x1A, 0x1A, 0x1A, 0x1B, 0x1B, 0x1B, 0x1B, > - 0x1C, 0x1C, 0x1C, 0x1C, 0x1D, 0x1D, 0x1D, 0x1D, > - 0x1E, 0x1E, 0x1E, 0x1E, 0x1F, 0x1F, 0x1F, 0x1F, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > }; Same here. Hauke