Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:48358 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707Ab0LGSMt (ORCPT ); Tue, 7 Dec 2010 13:12:49 -0500 Subject: Re: [PATCH 5/5] mac80211: fix issuing idle calls when device open count is 0 From: Johannes Berg To: "Luis R. Rodriguez" Cc: Luis Rodriguez , "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , Amod Bodas , "pstew@google.com" , "stable@kernel.org" In-Reply-To: References: <1291690135-4535-1-git-send-email-lrodriguez@atheros.com> <1291690135-4535-6-git-send-email-lrodriguez@atheros.com> <1291714709.3607.2.camel@jlt3.sipsolutions.net> <1291736887.3607.47.camel@jlt3.sipsolutions.net> <1291737298.3607.48.camel@jlt3.sipsolutions.net> <20101207155916.GA1855@tux> <1291743121.3607.50.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Date: Tue, 07 Dec 2010 19:12:47 +0100 Message-ID: <1291745567.3607.52.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2010-12-07 at 10:04 -0800, Luis R. Rodriguez wrote: > On Tue, Dec 7, 2010 at 9:32 AM, Johannes Berg wrote: > > On Tue, 2010-12-07 at 07:59 -0800, Luis R. Rodriguez wrote: > > > >> @@ -301,7 +301,7 @@ static void __ieee80211_scan_completed_finish(struct ieee80211_hw *hw, > >> } > >> > >> mutex_lock(&local->mtx); > >> - ieee80211_recalc_idle(local); > >> + ieee80211_recalc_idle_force(local); > >> mutex_unlock(&local->mtx); > > > > This is the change that I don't think is necessary. > > Without this resume fails. In what situation? When you just suspend while things are up&running, or if you suspend with interfaces down? It doesn't make sense anyway, so something's going on in the rest of the scan code -- we should be canceling scans properly when going down and when suspending, well before any of this becomes relevant. johannes