Return-path: Received: from mail-bw0-f45.google.com ([209.85.214.45]:54622 "EHLO mail-bw0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752368Ab0LGUAU (ORCPT ); Tue, 7 Dec 2010 15:00:20 -0500 Received: by bwz16 with SMTP id 16so445776bwz.4 for ; Tue, 07 Dec 2010 12:00:18 -0800 (PST) Message-ID: <4CFE9263.4060108@lwfinger.net> Date: Tue, 07 Dec 2010 14:00:35 -0600 From: Larry Finger MIME-Version: 1.0 To: ikorot@earthlink.net CC: Hauke Mehrtens , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org Subject: Re: [PATCH 1/4] b43: N-PHY: update init tables References: <5001512.1291751372533.JavaMail.root@elwamui-cypress.atl.sa.earthlink.net> In-Reply-To: <5001512.1291751372533.JavaMail.root@elwamui-cypress.atl.sa.earthlink.net> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 12/07/2010 01:49 PM, ikorot@earthlink.net wrote: >> One reason is that these tables changed from non-zero to zero values between >> Broadcom driver 4.174.64.19 and 5.10.56.46. As they might change again, I think >> we should retain the full version. > > Is there a way to check for version of the driver? > This way whoever uses old one won't be screwed... That will not be a problem as no older version of b43 works at all with b43. To help you understand this change, when the 4.174.64.19 Broadcom driver was reverse-engineered, the tables had non-zero values. Rafel later compared the trace dumps of b43 with the latest version of wl and found that the values are now zero. When I rechecked driver 5.10.56.46, I found them to be zero there as well and changed the specs. Larry